search

leoncvlt / loconotion

📄 Python tool to turn Notion.so pages into lightweight, customizable static websites
841 stars 132 forks source link

Alternative project repo #133

Closed sueszli closed 1 year ago

sueszli commented 1 year ago

Hello everyone,

I would like to invite you all to join me on my project called "notionSnapshot", which is a refactored and trimmed down version of "loconotion". My aim was to make it more maintainable and easy to understand so more people can contribute.

I have added several issues to this repository and sent in pull requests that unfortunately got ignored, which is why I have decided to take ownership of this mission. I believe that this project has the potential to become a great resource for developers, and I would love for you to join me in contributing to it.

The project is available here: https://github.com/sueszli/notionSnapshot

Thank you, and I look forward to working with you!

leoncvlt commented 1 year ago

You opened one pull request (#114) which added one line of code to fix the docker deployement (a feature I personally I don't really care about).

We're in the open source community and everyone's welcome to propose changes and build on existing projects, but rather than fork the project it seems you decided to just copy all the code and create a new repo from scratch, without an ounce of credit to the original author. Plus you created 3 issues all advertising your discord and the "resurrection" of the project. It seems all very spammy and self-centered to me, can't say I'm a fan.

Regardless, wish you all the best on your project and coding efforts.

sueszli commented 1 year ago

Thank you for taking the time to respond to my message. I want to apologize for any offense that I may have caused with my actions. I understand now that I should have tried to communicate better with you before forking the project, and I regret not doing so. This is my first time trying to build on an existing project, and I realize that there is a lot that I still have to learn about collaborating with others in the open source community.

I did try to contact you on LinkedIn before sending the message, but I realize now that I should have been more persistent in trying to reach you. I am sorry for any frustration or confusion that my actions may have caused.

You are right that I should have given more credit to the original author, and I apologize for any lack of recognition that I may have shown. I deeply admire your work and loconotion has been a huge inspiration to me. I would like to rectify this by giving proper attribution to you and the original project in the README file of my repository.

Regarding the issues that I raised, I understand now that they may have come across as self-promotion, and I am sorry for any spammy behavior that I may have exhibited. I will take down those issues immediately and will refrain from such behavior in the future.

Once again, I am sorry for any inconvenience that I may have caused. I will take your feedback to heart and will do everything in my power to be a more considerate and collaborative member of the open source community.

Thank you for your time and attention.

stefnotch commented 1 year ago

Disclaimer: I'm not a lawyer, and none of this is legal advice.

Just adding my two cents from a licensing perspective: I was under the impression that contributing to loconotion is less than ideal, since loconotion doesn't have a license. That means loconotion falls back to the "all rights reserved" licensing. Which also means that as an end user, simply using this project is on shaky legal grounds.

Worse yet, pull request authors do hand over ownership of their code. As I understand it, this leads to the actual license of loconotion being a patchwork of "leoncvlt owns the majority" and "the lovely person who created the pull request owns those lines of code". Which means that technically, any pull request author could serve GitHub a valid DMCA takedown request.

There was a pull request which added a license (of questionable quality) in the past, sadly that one never received any attention https://github.com/leoncvlt/loconotion/pull/45

So doing what sueszli apparently did, which is taking the code and rewriting all of it doesn't seem entirely outlandish to me.

sueszli commented 1 year ago

but rather than fork the project it seems you decided to just copy all the code and create a new repo from scratch

fixed

without an ounce of credit to the original author

fixed, please let me know what you think

sueszli commented 1 year ago

@leoncvlt I've worked on the fork quite some time now with friends :3

Do you think that I have mentioned Loconotion frequently enough and given the contributors enough credit or is there a way I could improve further?

If I would make a PR, would you consider merging it or has my fork diverged too much from the initial vision?

sueszli commented 1 year ago

:( still no updates

kmlbgn commented 1 year ago

Not only contributing is not ideal as is, but the only participation of repo owner to this thread is a complaint while OP has been extending hands multiple times. This project is not longer being maintained by the look of the numbers of issue piling up.. why calling out someone that is genuinely trying to keep it up.

sueszli commented 1 year ago

@kmlbgn you can just archive projects to make it obvious.

kmlbgn commented 1 year ago

@kmlbgn you can just archive projects to make it obvious.

I'm not the repo owner. you misread what I say I believe. I'm actually backing you up

sueszli commented 1 year ago

@kmlbgn no I'm grateful for your support. i put in an insane amount of time to completely rewrite this project.

i just wish the owner @leoncvlt would archive loconotion.

i should have said "exactly, the owner should just archive it to make it obvious" to avoid our misunderstanding.

kmlbgn commented 1 year ago

@sueszli One question tho, have you guys stopped working on Snapshot to focus on Backup ? If yes why ? Notion's export to html is quiet bad imo, e.g: it also exports the entire trash with it

sueszli commented 1 year ago

@kmlbgn so the table in this readme should summarize why: https://github.com/sueszli/notionBackup/blob/main/README.md (webscraping == notionsnapshot)

feel free to ask more questions. i'm glad you're interested in the project.

sueszli commented 1 year ago

in general: notionsnapshot is great for aesthetic purposes / keeping the look, but it's just way too unreliable.

notionbackup just fixes a couple of things that the default exporter does wrong and although not as pretty, it's super reliable and gets the job done.

i haven't abandoned any of the projects, i'd accept any pull request and review everything. i'm just not implementing feature requests from users (except when i receive donations).

leoncvlt commented 1 year ago

Edited README.md with links to NotionSnapshot, thought I would eventually come back to this but given that I don't use Notion anymore I realistically don't see that happening with me being busy with other things. Sorry about any hostility you might have felt coming off my messages, best of luck to all the notioners out there!

sueszli commented 1 year ago

Thanks Leon.

This was an unexpected turn of events.

stefnotch commented 1 year ago

@leoncvlt Thank you so much for being really awesome! (Both for originally building this tool, and for eventually passing the torch.) I don't use Notion, nor any of these tools, but I still know that appreciating good developers is the least I can do.