search

leonhartX / gas-github

sync gas code to github
https://chrome.google.com/webstore/detail/lfjcgcmkmjjlieihflfhjopckgpelofo
MIT License
3.5k stars 70 forks source link

Manifest V3 Support #160

Open Hell-K opened 2 years ago

Hell-K commented 2 years ago
gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [-](https://dashboard.gitguardian.com/incidents/secrets) | Base64 Basic Authentication | 3723f8d58e272d36c9eba8bde636180a23db437d | options/options.js | [View secret](https://github.com/leonhartX/gas-github/commit/3723f8d58e272d36c9eba8bde636180a23db437d#diff-3bf373e3dd1ccf29907dce64d9b00107R296) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/generics/base64_basic_auth#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

leonhartX commented 2 years ago

Thanks for this! will take a look later

Hell-K commented 2 years ago

Welcome!

I understand that the secret uncovered is actually an old token that I removed from the extension and so it's appearing in the commit and that's why GitGuardian is not completely happy but I don't think it's a problem. I'm sure you must have revoked it a long time ago.

However, I have no idea why the build-and-test is failing. I've personally been using my modified version of the extension and it's working fine so far.