interval ntp issue

[ani123446]

hello everyone, Am from India. Can anyone help me with line 25. what should I put there if am from India.

unsigned long intervalNTP = 24 60 60000; // Request a new NTP time every 24 hours

[brettoliver]

I would have thought you want to change line 23? unsigned long timeZone = 1.0; // Change this value to your local timezone (in my case +1 for Amsterdam)

[ani123446]

My clock is working but the time is not proper even though i change to my time zone. (Its +5:30 for india). But idk abt that line 25 what should i put there?

[brettoliver]

Line 25 is the interval that the clock checks the NTP time. it is set to check once every 24 hours. What time is your clock showing and what is the local time?

[brettoliver]

Line 24 Is this set to you local time server? in.pool.ntp.org

Set this to a ntpserver nearby, check this site for a list of servers: https://www.pool.ntp.org/en/

[ani123446]

yes line 24 is set to my local server (in.pool.ntp.org). My time here is 10:13 but its showing around 5:23

[brettoliver]

Have you typed in +5.5 or just 5.5? Try changing it. I'm just guessing here.

[ani123446]

in india GMT is +5.30

[brettoliver]

yeah 0.3 is 0.5 in hours? Maybe why your minutes are out?

[ani123446]

yes 0.3 in hours.

[brettoliver]

Can you paste your code?

[ani123446]

/* WiFi connected round LED Clock. It gets NTP time from the internet and translates to a 60 RGB WS2812B LED strip.

If you have another orientation where the wire comes out then change the methods getLEDHour and getLEDMinuteOrSecond

Happy programming, Leon van den Beukel, march 2019

---

NTP and summer time code based on: https://tttapa.github.io/ESP8266/Chap15%20-%20NTP.html https://github.com/SensorsIot/NTPtimeESP/blob/master/NTPtimeESP.cpp (for US summer time support check this link)

*/

include

include

include

include

define DEBUG_ON

const char ssid[] = "Aniket"; // Your network SSID name here const char pass[] = "lalbalpal"; // Your network password here unsigned long timeZone = +5.30; // Change this value to your local timezone (in my case +1 for Amsterdam) const char NTPServerName = "in.pool.ntp.org"; // Change this to a ntpserver nearby, check this site for a list of servers: https://www.pool.ntp.org/en/ unsigned long intervalNTP = 24 60 * 60000; // Request a new NTP time every 24 hours

// Change the colors here if you want. // Check for reference: https://github.com/FastLED/FastLED/wiki/Pixel-reference#predefined-colors-list // You can also set the colors with RGB values, for example red: // CRGB colorHour = CRGB(255, 0, 0); CRGB colorHour = CRGB::Red; CRGB colorMinute = CRGB::Green; CRGB colorSecond = CRGB::Blue; CRGB colorHourMinute = CRGB::Yellow; CRGB colorHourSecond = CRGB::Magenta; CRGB colorMinuteSecond = CRGB::Cyan; CRGB colorAll = CRGB::White;

// Set this to true if you want the hour LED to move between hours (if set to false the hour LED will only move every hour)

define USE_LED_MOVE_BETWEEN_HOURS true

// Cutoff times for day / night brightness.

define USE_NIGHTCUTOFF false // Enable/Disable night brightness

define MORNINGCUTOFF 8 // When does daybrightness begin? 8am

define NIGHTCUTOFF 20 // When does nightbrightness begin? 10pm

define NIGHTBRIGHTNESS 20 // Brightness level from 0 (off) to 255 (full brightness)

ESP8266WiFiMulti wifiMulti;
WiFiUDP UDP;
IPAddress timeServerIP;
const int NTP_PACKET_SIZE = 48;
byte NTPBuffer[NTP_PACKET_SIZE];

unsigned long prevNTP = 0; unsigned long lastNTPResponse = millis(); uint32_t timeUNIX = 0; unsigned long prevActualTime = 0;

define LEAP_YEAR(Y) ( ((1970+Y)>0) && !((1970+Y)%4) && ( ((1970+Y)%100) || !((1970+Y)%400) ) )

static const uint8_t monthDays[] = {31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31};

define NUM_LEDS 60

define DATA_PIN D6

CRGB LEDs[NUM_LEDS];

struct DateTime { int year; byte month; byte day; byte hour; byte minute; byte second; byte dayofweek; };

DateTime currentDateTime;

void setup() {

FastLED.delay(3000); FastLED.addLeds<WS2812B, DATA_PIN, GRB>(LEDs, NUM_LEDS);

Serial.begin(115200);
delay(10); Serial.println("\r\n");

startWiFi(); startUDP();

if(!WiFi.hostByName(NTPServerName, timeServerIP)) { Serial.println("DNS lookup failed. Rebooting."); Serial.flush(); ESP.reset(); } Serial.print("Time server IP:\t"); Serial.println(timeServerIP);

Serial.println("\r\nSending NTP request ..."); sendNTPpacket(timeServerIP);
}

void loop() { unsigned long currentMillis = millis();

if (currentMillis - prevNTP > intervalNTP) { // If a minute has passed since last NTP request prevNTP = currentMillis; Serial.println("\r\nSending NTP request ..."); sendNTPpacket(timeServerIP); // Send an NTP request }

uint32_t time = getTime(); // Check if an NTP response has arrived and get the (UNIX) time if (time) { // If a new timestamp has been received timeUNIX = time; Serial.print("NTP response:\t"); Serial.println(timeUNIX); lastNTPResponse = currentMillis; } else if ((currentMillis - lastNTPResponse) > 3600000) { Serial.println("More than 1 hour since last NTP response. Rebooting."); Serial.flush(); ESP.reset(); }

uint32_t actualTime = timeUNIX + (currentMillis - lastNTPResponse)/1000; if (actualTime != prevActualTime && timeUNIX != 0) { // If a second has passed since last update prevActualTime = actualTime; convertTime(actualTime);

for (int i=0; i<NUM_LEDS; i++) 
  LEDs[i] = CRGB::Black;

int second = getLEDMinuteOrSecond(currentDateTime.second);
int minute = getLEDMinuteOrSecond(currentDateTime.minute);
int hour = getLEDHour(currentDateTime.hour, currentDateTime.minute);

// Set "Hands"
LEDs[second] = colorSecond;
LEDs[minute] = colorMinute;  
LEDs[hour] = colorHour;  

// Hour and min are on same spot
if ( hour == minute)
  LEDs[hour] = colorHourMinute;

// Hour and sec are on same spot
if ( hour == second)
  LEDs[hour] = colorHourSecond;

// Min and sec are on same spot
if ( minute == second)
  LEDs[minute] = colorMinuteSecond;

// All are on same spot
if ( minute == second && minute == hour)
  LEDs[minute] = colorAll;

if ( night() && USE_NIGHTCUTOFF == true )
  FastLED.setBrightness (NIGHTBRIGHTNESS); 

FastLED.show();

}
}

byte getLEDHour(byte hours, byte minutes) { if (hours > 12) hours = hours - 12;

byte hourLED; if (hours <= 5) hourLED = (hours 5) + 30; else hourLED = (hours 5) - 30;

if (USE_LED_MOVE_BETWEEN_HOURS == true) { if (minutes >= 12 && minutes < 24) { hourLED += 1; } else if (minutes >= 24 && minutes < 36) { hourLED += 2; } else if (minutes >= 36 && minutes < 48) { hourLED += 3; } else if (minutes >= 48) { hourLED += 4; } }

return hourLED;
}

byte getLEDMinuteOrSecond(byte minuteOrSecond) { if (minuteOrSecond < 30) return minuteOrSecond + 30; else return minuteOrSecond - 30; }

void startWiFi() { wifiMulti.addAP(ssid, pass);

Serial.println("Connecting"); byte i = 0; while (wifiMulti.run() != WL_CONNECTED) {
delay(250); Serial.print('.'); LEDs[i++] = CRGB::Green; FastLED.show();
} Serial.println("\r\n"); Serial.print("Connected to "); Serial.println(WiFi.SSID());
Serial.print("IP address:\t"); Serial.print(WiFi.localIP());
Serial.println("\r\n"); }

void startUDP() { Serial.println("Starting UDP"); UDP.begin(123); // Start listening for UDP messages on port 123 Serial.print("Local port:\t"); Serial.println(UDP.localPort()); Serial.println(); }

uint32_t getTime() { if (UDP.parsePacket() == 0) { // If there's no response (yet) return 0; } UDP.read(NTPBuffer, NTP_PACKET_SIZE); // read the packet into the buffer // Combine the 4 timestamp bytes into one 32-bit number uint32_t NTPTime = (NTPBuffer[40] << 24) | (NTPBuffer[41] << 16) | (NTPBuffer[42] << 8) | NTPBuffer[43]; // Convert NTP time to a UNIX timestamp: // Unix time starts on Jan 1 1970. That's 2208988800 seconds in NTP time: const uint32_t seventyYears = 2208988800UL; // subtract seventy years: uint32_t UNIXTime = NTPTime - seventyYears; return UNIXTime; }

void sendNTPpacket(IPAddress& address) { memset(NTPBuffer, 0, NTP_PACKET_SIZE); // set all bytes in the buffer to 0 // Initialize values needed to form NTP request NTPBuffer[0] = 0b11100011; // LI, Version, Mode // send a packet requesting a timestamp: UDP.beginPacket(address, 123); // NTP requests are to port 123 UDP.write(NTPBuffer, NTP_PACKET_SIZE); UDP.endPacket(); }

void convertTime(uint32_t time) { // Correct time zone time += (3600 * timeZone);

currentDateTime.second = time % 60; currentDateTime.minute = time / 60 % 60; currentDateTime.hour = time / 3600 % 24; time /= 60; // To minutes time /= 60; // To hours time /= 24; // To days currentDateTime.dayofweek = ((time + 4) % 7) + 1; int year = 0; int days = 0; while ((unsigned)(days += (LEAP_YEAR(year) ? 366 : 365)) <= time) { year++; } days -= LEAP_YEAR(year) ? 366 : 365; time -= days; // To days in this year, starting at 0
days = 0; byte month = 0; byte monthLength = 0; for (month = 0; month < 12; month++) { if (month == 1) { // February if (LEAP_YEAR(year)) { monthLength = 29; } else { monthLength = 28; } } else { monthLength = monthDays[month]; }

if (time >= monthLength) {
  time -= monthLength;
} else {
  break;
}

}

currentDateTime.day = time + 1; currentDateTime.year = year + 1970; currentDateTime.month = month + 1;

// Correct European Summer time if (summerTime()) { currentDateTime.hour += 1; }

ifdef DEBUG_ON

Serial.print(currentDateTime.year); Serial.print(" "); Serial.print(currentDateTime.month); Serial.print(" "); Serial.print(currentDateTime.day); Serial.print(" "); Serial.print(currentDateTime.hour); Serial.print(" "); Serial.print(currentDateTime.minute); Serial.print(" "); Serial.print(currentDateTime.second); Serial.print(" day of week: "); Serial.print(currentDateTime.dayofweek); Serial.print(" summer time: "); Serial.print(summerTime()); Serial.print(" night time: "); Serial.print(night());
Serial.println();

endif

}

boolean summerTime() {

if (currentDateTime.month < 3 || currentDateTime.month > 10) return false; // No summer time in Jan, Feb, Nov, Dec if (currentDateTime.month > 3 && currentDateTime.month < 10) return true; // Summer time in Apr, May, Jun, Jul, Aug, Sep if (currentDateTime.month == 3 && (currentDateTime.hour + 24 currentDateTime.day) >= (3 + 24 (31 - (5 currentDateTime.year / 4 + 4) % 7)) || currentDateTime.month == 10 && (currentDateTime.hour + 24 currentDateTime.day) < (3 + 24 (31 - (5 currentDateTime.year / 4 + 1) % 7))) return true; else return false; }

boolean night() { return ( currentDateTime.hour >= NIGHTCUTOFF ) || ( currentDateTime.hour <= MORNINGCUTOFF );
}

[brettoliver]

I think 5.3 is 5 hours 20mins. 5.5 is 5hours 30mins? Try just 5.5 without the plus and see what time you get.

[ani123446]

with 5.5 it coming 1.17but the time here is 12.47

[brettoliver]

Have you tried 0 just to see what the NTP server gives out?

[ani123446]

yes but correct time is not showing

[ani123446]

with 4.50 or 4.5 or 4.30 its showing time but 30 mins fast from my country time

[Boris-jivotnoe]

I have the same problem, the clock is 5 hours behind and the minutes are 30 minutes behind, the LED strip is the same as in the project, what can be done?