leopard-js / leopard

Library for making Scratch-like projects with JavaScript.
https://leopardjs.com
MIT License
138 stars 26 forks source link

Expose types in package.json #191

Closed mybearworld closed 6 months ago

mybearworld commented 6 months ago

Leopard is written in Typescript, and the type definitions are already part of the Leopard package. However, they aren't actually set in the package.json, so Typescript doesn't see them.

    "main": "dist/index.umd.js",
    "module": "dist/index.esm.js",
+   "types": "dist/index.d.ts",
towerofnix commented 6 months ago

@adroitwhiz Pinging you for attention on this, is that all there is to providing Leopard's types to package consumers (what I'm assuming this issue is about)? Pretty much normal for TypeScript projects, no additional changes needed?

adroitwhiz commented 6 months ago

Yup, pretty much.

towerofnix commented 6 months ago

@mybearworld Would you like to make a pull request? 👾✨

mybearworld commented 6 months ago

Sure, I made one.