Fix Linting errors in NodeCloud - Githubissues

leopardslab / nodecloud-legacy

[DEPERECATED] REFER: nodecloud | The Node.js API for open cloud

Apache License 2.0

55 stars 101 forks source link

Fix Linting errors in NodeCloud #25

Closed AdhyanDhull closed 6 years ago

AdhyanDhull commented 6 years ago

Before : https://drive.google.com/open?id=1qyK-_f9mL9u3YUorfngzEmwzVqGr9JlR After : https://drive.google.com/open?id=1xg9R1iiQkp_q1teDefu-j15D29StrnR8

Kindly ignore the first commit.

What did you implement:

Closes #XXXXX

How did you implement it:

How can we verify it:

Todos:

[ ] Write tests
[ ] Write documentation
[ ] Fix linting errors
[ ] Make sure code coverage hasn't dropped
[ ] Provide verification config / commands / resources
[ ] Enable "Allow edits from maintainers" for this PR
[ ] Update the messages below

Is this ready for review?: NO Is it a breaking change?: NO

rehrumesh commented 6 years ago

Great work

rehrumesh commented 6 years ago

Hi @AdhyanDhull I have mistakenly merged this PR. You had removed

const assert = chai.assert;     
 const providers = require("../../lib/providers");      
 const nodeCloud = require("../../lib");        
 const nock = require("nock");

These lines should not be removed. Hense I have reverted the changes. Please open a new PR with only the other changes.