Peer Dependency of messageformat seems to be wrong

lephyrus / ngx-translate-messageformat-compiler

Advanced pluralization (and more) for ngx-translate, using standard ICU syntax which is compiled with the help of messageformat.js.

MIT License

93 stars 29 forks source link

Peer Dependency of messageformat seems to be wrong #41

Closed penghuili closed 5 years ago

penghuili commented 5 years ago

The peerDependencies of messageformat:

"messageformat": ">=2.0.0 <=2.0.2 || >2.0.4 <3.0.0"

But the current lastest version of messageformat is 2.0.4, so shouldn't it be:

"messageformat": ">=2.0.0 <=2.0.2 || >=2.0.4 <3.0.0"

vtolstov commented 5 years ago

gentle ping...

lephyrus commented 5 years ago

@penghuili @vtolstov You're absolutely right of course. 👍 Sorry for the very late answer. Since 2.0.5 is out in the meantime, I guess this is not too important now. I'll still fix it in the next release.

lephyrus commented 5 years ago

Actually, I was right the first time. Both 2.0.3 and 2.0.4 were a problem for us because of this: https://github.com/messageformat/messageformat/pull/210