search

lessthanoptimal / ejml

A fast and easy to use linear algebra library written in Java for dense, sparse, real, and complex matrices.
https://ejml.org
565 stars 117 forks source link

Feature/simple refresh #171

Closed lessthanoptimal closed 1 year ago

lessthanoptimal commented 1 year ago

Thank you for your contribution to the EJML project.

This PR adds much improved support for complex matrices to SimpleMatrix

Before submitting this PR, please make sure:

lessthanoptimal commented 1 year ago

@JozsefKutas could you review this PR? There's another PR being blocked by this one.

lessthanoptimal commented 1 year ago

Went with your suggestion on changing stripReal() to real(). stripReal() was used since that's what was in the procedural API. Not sure why I went with that instead of the much more common function names. Also thanks for the suggested changes. I accepted and squashed them into a single commit.

lessthanoptimal commented 1 year ago

@JozsefKutas For complex divide, do you mean element wise division or A/B = A*inv(B)? Going to merge this PR now since it's already huge. Any new functions can be a new PR.

JozsefKutas commented 1 year ago

I meant dividing a matrix by a complex scalar, similar to plusComplex, minusComplex and scaleComplex.