lessthanoptimal / ejml

A fast and easy to use linear algebra library written in Java for dense, sparse, real, and complex matrices.
https://ejml.org
565 stars 117 forks source link

Documentation additions and changes for SimpleMatrix #188

Closed JozsefKutas closed 1 year ago

JozsefKutas commented 1 year ago

This PR contains various documentation additions/changes for SimpleMatrix:

JozsefKutas commented 1 year ago

Btw, for the SimpleMatrix#random_XXXX static factory methods, I say that values are drawn from a uniform distribution inclusive of the lower bound and exclusive of the upper bound, but the docs in RandomMatrices_XXXX say the distribution is inclusive on both ends. I think this is a mistake? Not that it makes any difference in practice.

lessthanoptimal commented 1 year ago

Just glanced at this and it looks great. It will probably be a week before I can do a proper review of everything since my day job is keeping me very busy at the moment.

JozsefKutas commented 1 year ago

No problem, I've been in the same position for a while now.