search

lettucecfd / lettuce

Computational Fluid Dynamics based on PyTorch and the Lattice Boltzmann Method
MIT License
222 stars 39 forks source link

Merge cuda_native Code Generator into master - Comes with multiple breaking Interface changes #173

Closed rawbby closed 3 months ago

rawbby commented 4 months ago

closes #134 closes #146 closes #166 closes #181 closes #183

PhiSpel commented 4 months ago

@rawbby I would like to help resolving the last few issues so that we can merge.

  1. Will you deal with and resolve your comments?
  2. I tried activating CI by changing the workflow file. It did not work for pull-requests: types: [review_requested]. Do you know how to fix that without explicitly refering to your branch?
PhiSpel commented 4 months ago

@McBs the tests ran perfectly fine on my local machine. Is sth. wrong with the workflow file?

McBs commented 4 months ago

@McBs the tests ran perfectly fine on my local machine. Is sth. wrong with the workflow file?

Unfortunately, I cannot confirm this. We are encountering a Numpy-Bool error (on my local machine) and a 'Cuda not available' issue. Currently, we are unable to test the CUDA device on the provided runner that handles the CI.

For this issue, I will set up a weekly CI job that runs on my workstation.

PhiSpel commented 3 months ago

@McBs this commit https://github.com/lettucecfd/lettuce/commit/818d50a4e79c940558fb7e56ce55c1c718ab9ccf does not seem to solve the issue on GitHub CI, just fyi. Let's check back on it tomorrow.