added a test for dump and load

lettucecfd / lettuce

Computational Fluid Dynamics based on PyTorch and the Lattice Boltzmann Method

MIT License

222 stars 39 forks source link

added a test for dump and load #224

Closed PhiSpel closed 3 months ago

PhiSpel commented 3 months ago

Description

closes #119

Checklist

[x] This pull request is associated to an issue
[x] This PR contains a description
[x] ~Did you add a new method? If so, you need to~
- [x] ~add method description~
- [x] ~maybe mention class in the corresponding __init__~
- [x] ~add an example using the method in examples/advanced_flows/ or examples/simple_flows/~
- [x] add a test in tests/
[x] Add someone else as reviewer and wait for approval before merging.

pep8speaks commented 3 months ago

Hello @PhiSpel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-08-20 12:47:30 UTC

PhiSpel commented 3 months ago

@Olllom @robert-DL, the new lettuce architecture only stores the f's, which is enough IMHO. I did add a test on which I was (locally) able to fully stretch the GPU capacity and still store and reload the f's. It also contains a suggestion how to test a dump-load workflow which also stores attributes. However, I was not able to get this going quickly. Does this solve #119 for you?