lewissbaker / cppcoro

A library of C++ coroutine abstractions for the coroutines TS
MIT License
3.43k stars 472 forks source link

Make recursive_generator [[nodiscard]] like generator #146

Closed gomez-addams closed 4 years ago

gomez-addams commented 4 years ago

Using recursive_generator I was caught off guard by the lack of a [[nodiscard]] specifier, allowing a foolish typo to persist in my code for weeks. This change enables the same warnings generator enjoys, likewise with the change to shared_task enabling warnings like for task.

lewissbaker commented 4 years ago

Thanks for the PR. Looks good!