search

lewissbaker / cppcoro

A library of C++ coroutine abstractions for the coroutines TS
MIT License
3.43k stars 472 forks source link

Remove possible warnings with redefinitions #71

Closed attila0x2A closed 6 years ago

attila0x2A commented 6 years ago

If the library is used as part of a bigger project some definitions can be provided via external build files.

lewissbaker commented 6 years ago

So the issue you're trying to solve here is that you're already defining WIN32_LEAN_AND_MEAN on the command-line in your build system which is compiling cppcoro sources directly rather than using the output of the cake build system?

There are a couple of new files in the sockets2 branch that may require compilation without WIN32_LEAN_AND_MEAN defined. I'll try out this change with those branches but otherwise it seems like a reasonable change to me.

attila0x2A commented 6 years ago

So the issue you're trying to solve here is that you're already defining WIN32_LEAN_AND_MEAN on the command-line in your build system which is compiling cppcoro sources directly rather than using the output of the cake build system?

Yes, exactly.