search

lexik / LexikPayboxBundle

LexikPayboxBundle eases the implementation of the Paybox payment system
MIT License
40 stars 47 forks source link

Handle multiple paybox accounts #91

Open sarramegnag opened 6 years ago

sarramegnag commented 6 years ago

Greetings,

Huge PR related to https://github.com/lexik/LexikPayboxBundle/issues/89. Unfortunatly I think it would be too hard to handle backward compatibility.

Thanks for your review and feel free to ask if you have any questions.

Regards,

Guillaume

acidjames commented 5 years ago

@spike31 Is this PR worth a v3 tag ?

(i've changed jobs now and i won't be able to continue support on this plugin unfortunately but i think this PR is worth some investigation)

James

sarramegnag commented 5 years ago

Just for the information, we're using my fork in production since one year and a half. No problem until now with direct payments (we're not using recurring payments).

gilles-g commented 5 years ago

Well... Handle multiple accounts is not common.

I'm not sure this is a feature we would like to see.

Or create an other bundle with a dps on that bundle, i don't know. Maybe we can mention your fork on the documentation, just in case