Closed yann-eugone closed 5 years ago
I do not know your compatibility strategy so I tried to update Travis matrix to test everything, look like it is harder than expected, specialy because phpunit version is not required.
Can someone tell me how you want me to fix this ?
@yann-eugone Hi, Have a look on https://github.com/lexik/LexikJWTAuthenticationBundle/blob/master/.travis.yml
The strategy is to test for each php version, each symfony version
Maybe change the phpunit requirements for something like that "symfony/phpunit-bridge": "^3.4|^4.0",
Maybe it is just me, but do you think that testing something like PHP 7.3 Symfony 2.7 is a good idea ?
Tests are green, I had to replace symfony/phpunit-bridge
with phpunit/phpunit
to be sure of PHPUnit version
@yann-eugone look at this lines
https://github.com/lexik/LexikJWTAuthenticationBundle/blob/master/.travis.yml#L5-L13
We don't want to test php 7.3 with sf 2.7
Ah I understand, I said each php version for each sf version. It was a mistake :)
Green again, matrix took ~11 minutes (instead of ~45 minutes previously) to run
Nice job! I will create a release
Please let me know if there is something else I can do to help.