lf-edge / edge-home-orchestration-go

Home Edge Project in LF Edge - Edge Orchestration for home edge devices to enabling smart home use cases.
https://www.lfedge.org/projects/homeedge/
Apache License 2.0
93 stars 51 forks source link

Fix fossology workflow #736

Closed tdrozdovsky closed 11 months ago

tdrozdovsky commented 11 months ago

Description

Fix fossology error:

Traceback (most recent call last):
  File "/bin/fossologyscanner", line 273, in <module>
    sys.exit(main(args))
  File "/bin/fossologyscanner", line 231, in main
    api_config = get_api_config()
  File "/bin/fossologyscanner", line 65, in get_api_config
    api_config.project_orig = os.environ['GITHUB_REPO_OWNER']
  File "/usr/lib/python3.9/os.py", line 679, in __getitem__
    raise KeyError(key) from None
KeyError: 'GITHUB_REPO_OWNER'
Error: Process completed with exit code 1.

Type of change

Test Configuration:

Checklist:

tdrozdovsky commented 11 months ago

I suggest looking at the error in test-suite separately, since locally the tests work correctly, and catching this error will be quite difficult since it depends on the hardware where the github->action is running

ERRO[2023-12-12T16:40:55Z]cpu.go:63 readCPUUsage                                              
ERRO[2023-12-12T16:40:55Z]cpu.go:63 readCPUUsage                                              
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
--- FAIL: TestInfo (0.04s)
    --- FAIL: TestInfo/Success (0.04s)
        cpu_test.go:389: unexpected fail
FAIL
coverage: 96.3% of statements
FAIL    github.com/lf-edge/edge-home-orchestration-go/internal/common/resourceutil/cpu  1.045s
tiokim commented 11 months ago

I suggest looking at the error in test-suite separately, since locally the tests work correctly, and catching this error will be quite difficult since it depends on the hardware where the github->action is running

ERRO[2023-12-12T16:40:55Z]cpu.go:63 readCPUUsage                                              
ERRO[2023-12-12T16:40:55Z]cpu.go:63 readCPUUsage                                              
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
--- FAIL: TestInfo (0.04s)
    --- FAIL: TestInfo/Success (0.04s)
        cpu_test.go:389: unexpected fail
FAIL
coverage: 96.3% of statements
FAIL  github.com/lf-edge/edge-home-orchestration-go/internal/common/resourceutil/cpu  1.045s

What about excluding resourceutil/cpu test from the workflow?

tdrozdovsky commented 11 months ago

I suggest looking at the error in test-suite separately, since locally the tests work correctly, and catching this error will be quite difficult since it depends on the hardware where the github->action is running

ERRO[2023-12-12T16:40:55Z]cpu.go:63 readCPUUsage                                              
ERRO[2023-12-12T16:40:55Z]cpu.go:63 readCPUUsage                                              
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
ERRO[2023-12-12T16:40:55Z]cpu.go:189 getCPUFreqCPUInfo EOF                                          
--- FAIL: TestInfo (0.04s)
    --- FAIL: TestInfo/Success (0.04s)
        cpu_test.go:389: unexpected fail
FAIL
coverage: 96.3% of statements
FAIL    github.com/lf-edge/edge-home-orchestration-go/internal/common/resourceutil/cpu  1.045s

What about excluding resourceutil/cpu test from the workflow?

I'll try to fix this later. If it doesn’t work out then we’ll exclude it.

sonarcloud[bot] commented 11 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud