search

lf1-io / padl

Functional deep learning
Apache License 2.0
106 stars 4 forks source link

362 full import #366

Closed wuhu closed 2 years ago

wuhu commented 2 years ago

Description

Fixes #362

codecov-commenter commented 2 years ago

Codecov Report

Merging #366 (32cb0d1) into main (3f45f1a) will increase coverage by 0.86%. The diff coverage is 90.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   87.03%   87.89%   +0.86%     
==========================================
  Files          15       15              
  Lines        2830     2917      +87     
==========================================
+ Hits         2463     2564     +101     
+ Misses        367      353      -14
Impacted Files Coverage Δ
padl/dumptools/sourceget.py 86.55% <28.57%> (-1.48%) :arrow_down:
padl/dumptools/symfinder.py 84.39% <88.00%> (+0.82%) :arrow_up:
padl/dumptools/inspector.py 91.88% <88.88%> (+0.10%) :arrow_up:
padl/transforms.py 91.34% <90.90%> (+1.15%) :arrow_up:
padl/dumptools/var2mod.py 92.93% <94.78%> (+1.10%) :arrow_up:
padl/dumptools/serialize.py 89.04% <100.00%> (ø)
padl/wrap.py 90.38% <100.00%> (+1.28%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f45f1a...32cb0d1. Read the comment docs.

sjrl commented 2 years ago

It looks like the failing test has to do with a convention in python 3.9. Here is the error message

>       assert dump == read_dump('othermodule_full_makeclasstransform_with_transforms')
E       AssertionError: assert 'from padl im...rm(a, b, c)\n' == 'from padl im...rm(a, b, c)\n'
E         Skipping 312 identical leading characters in diff, use -v to show
E         -    return (tests_material_transforms_in_module_CONST + k(y))
E         ?           -                                                -
E         +    return tests_material_transforms_in_module_CONST + k(y)
jasonkhadka commented 2 years ago

tests still failing for windows 3.9 here. Do we want to keep that support?

wuhu commented 2 years ago

@jasonkhadka I'll merge with failing windows tests and create an issue for it. We can decide later whether to drop support.