Closed eramdiaz closed 2 years ago
Merging #405 (6a571d7) into main (5aedf81) will increase coverage by
0.25%
. The diff coverage is20.00%
.
@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 87.35% 87.60% +0.25%
==========================================
Files 15 15
Lines 3012 2978 -34
==========================================
- Hits 2631 2609 -22
+ Misses 381 369 -12
Impacted Files | Coverage Δ | |
---|---|---|
padl/transforms.py | 91.60% <20.00%> (+0.69%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5aedf81...6a571d7. Read the comment docs.
Why did you decide to remove the top level marker?
This is supposed to solve the issue #404 (and #340), which describes a bug on the top level marker in a non edgy case. It is not a direct fix but I don't know how to solve it in a direct way. Let me know if you agree with the fix @wuhu :)
@eramdiaz I got that, I was trying to understand why you want to remove the marker entirely on the top level, rather than making it work in those cases - Is it not possible to fix it in a direct way or do you think it's too complicated / not worth the effort?
Description
Fixes #404 and #340 by not showing anymore the arrow at the highest level of the debugger (where the entire transform we are executing is shown).
For example, let
t
beThen, an error will be produced at the linear layer due to mismatching shapes. If we execute and call the debugger, at the first level we will get
as we see with no marker arrow. The deeper levels will already provide the marker arrow. For example, the next one is