search

lgi-devs / lgi

Dynamic Lua binding to GObject libraries using GObject-Introspection
MIT License
440 stars 70 forks source link

Add architecture ppc64le to travis build #255

Open zazzel opened 3 years ago

zazzel commented 3 years ago

Hi, I had added ppc64le support on Travis-ci and Its been success added and build. Kindly review and merge same.

Changes done are added ppc64le arch and exclude LUANAME=luajit-2.0 since its not supporting ppc64le Arch.

The Travis ci build logs can be verified from the link below. https://travis-ci.com/github/zazzel/lgi/builds/206977452 Please have a look.

Thank you

psychon commented 3 years ago

Hi,

thanks a lot for this PR.

However, I have to ask: Sorry, but what is the motivation for this? For example, one could add a Travis build with a big endian architecture because big endian causes much problems / has much differences. Or a reason could be "there were a couple of times where problems for ppc64 slipped through / could have been caught by CI". Is there something like this? Or are you just adding this PR "because".

My main issue with Travis in recent times has been build time. It only runs 3(?) jobs in parallel. Random data point:

zazzel commented 3 years ago

Hi Team, This PR adds CI support for the IBM Power Little Endian (ppc64le) architecture. The idea is to ensure that the builds on this architecture are continuously tested along with the Intel builds (amd64) as this is part of the ubuntu distro on that architecture as well and detecting (and fixing) any issues or failures early would help to ensure that we are always up to date. Thank you