search

liGhun / RSSharp

A .NET library giving access to various RSS feed aggregation services
61 stars 15 forks source link

Non-standard naming of functions. #1

Open robertiagar opened 9 years ago

robertiagar commented 9 years ago

I have a simple question. Just looking at the docs and some of the code, I saw that Feedly ApiCalls are named like: get, add_new_account, mark_entry_as_read instead of Get, AddNewAccount, MarkEntryAsRead as it would be using the standard C# naming conventions. Is there a reason for this?

liGhun commented 9 years ago

Just used the names of the API itself and ignored C# naming conventions by ignorance/not knowing about them. I should change it, shouldn't I?

robertiagar commented 9 years ago

It's not a big issue, but some people might not use the library because it's not using the standard naming conventions. When using the library the code might look a little "uggly" with non-standard naming. If you'd like I could fork the project and do most of the work myself.

liGhun commented 9 years ago

I've thought on refactoring anyway which will break current users anyway so I will change it when finding time. I will change to the naming convention but also want to get rid of the Tuple<ApiCallResponse, SOMETHING> using Response<MetaData, > instead.

robertiagar commented 9 years ago

Instead of renaming all of them, you could add the [Obsolete] (it probably has a few parameters too, not sure now) attribute to all function calls. That way when people update the library they'll get a warning message. Eventually you can remove the now obsolete methods without braking existing apps.

liGhun commented 9 years ago

BTW: are you planning to create a Windows client to Feedly, Fever, ...? If so maybe you want to have access to my stalled Menere solution (it is quite finished - I changed job recently and lost time to do anything)

robertiagar commented 9 years ago

I have a few podcasts rss in my Feedly account. I wanted to try and make a podcast client for people that have feedly/other rss. Getting the direct podcast urls might not contain all episodes. Feedly has a good archive that can help. That's about it really :)