Open LarsSchaaf opened 3 years ago
Do you need all these eggs checked in?
Sorry my mistake! I'll create new pull request
great work @LarsSchaaf, I will take a look later today
Sorry my mistake! I'll create new pull request
don't worry just remove from this one with a commit or force push a modified version to the same commit, no need for a new pull request :)
@LarsSchaaf do you actually need pytest-runner
for the testing of this module? I am under the impression that pytest
itself as installed gets everything done and pytest-runner
is deprecated/will be soon forgotten.
see:
wait are there even unittests? the tests we have are the science tests here, not ones that pytest
would be working with. I suppose that dependency can be deleted as a whole.
Finally, @LarsSchaaf can you confirm that you have installed this and used the testing of a model correctly and this reproduces the behaviour as before, or that you can document how the testing should be modified now?
Once all these are done, I think it would be useful if you asked @jameskermode and @bernstei to take a look as well, because they are the longest standing users here perhaps.
Done:
Still to do: Implementing
versioneer