search

libMesh / TIMPI

Templated Interface to MPI
GNU Lesser General Public License v2.1
12 stars 11 forks source link

Use FPE-safety flags when compiling TIMPI #129

Closed roystgnr closed 1 year ago

roystgnr commented 1 year ago

I don't think this is likely to ever be important, since we don't enable FPE in our test suite and we're surely never going to be doing vectorizable operations in the tiny parts of the TIMPI library that aren't header-only ... but I do want to keep ACSM in sync, and if FPE safety in TIMPI is ever important I'd rather we be too safe than not-safe-enough.

moosebuild commented 1 year ago

Job Coverage on 85be366 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

roystgnr commented 1 year ago

"Min clang", but unrelated. Looks like we missed a recipe to update to newer containers.

roystgnr commented 1 year ago

We're going to have some better clang containers ready soon so I'm not going to bother with a temporary update now. I did manually test that this update backs off gracefully when a compiler is too old to support -ftrapping-math