System reinit is not honoring _basic_system_only flag

libMesh / libmesh

libMesh github repository

http://libmesh.github.io

GNU Lesser General Public License v2.1

660 stars 286 forks source link

System reinit is not honoring _basic_system_only flag #1416

Closed YaqiWang closed 3 weeks ago

YaqiWang commented 7 years ago

The logic in init is fine, but if you look at ImplicitSystem::reinit(), you will see, it will initialize matrices and sparsity pattern no matter what _basic_system_only is true or false. I noticed this because in my JFNK calculations, I call set_basic_system_only () but later get a crash with adaptation turned on. In debug mode, I hit an assertion:

Assertion `ghost_coupling->size() == n_var' failed.
ghost_coupling->size() = 243659600
n_var = 12

YaqiWang commented 4 weeks ago

@roystgnr This seems having been resolved. I had a test skipped in Griffin but tried it during another work and the test does not have this issue anymore. Maybe this is due to some work done by @loganharbour on how MOOSE interfaces libMesh systems?

roystgnr commented 3 weeks ago

It looks to me like Fande fixed this in https://github.com/libMesh/libmesh/pull/2832