moosebuild
commented
1 month ago Job Coverage, step Generate coverage on eedf55b wanted to post the following:
Coverage
| 0c0313 | #3971 eedf55 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 62.33% | 62.33% | -0.00% | 100.00% | |
| Hits | 72903 | 72904 | +1 | 6 | |
| Misses | 44062 | 44065 | +3 | 0 | |
This comment will be updated on new commits.
roystgnr
A user suggested that they might have seen normal vectors inverted on a flipped Tri element. I couldn't reproduce that, but I did see normal vectors inverted on a flipped Edge element. This PR fixes that, and adds more unit tests to make sure such a gross error shouldn't recur. More subtle potential errors are going to need more subtle tests at some point.