libbpf / blazesym

blazesym is a library for address symbolization and related tasks
BSD 3-Clause "New" or "Revised" License
119 stars 25 forks source link

Make BPF symbolization tests end-to-end tests #888

Closed danielocfb closed 2 weeks ago

danielocfb commented 2 weeks ago

The BPF symbolization tests were added as unit tests, because they require a bunch of setup shenanigans that we only had available internally to the crate. Conceptually, however, these tests are very much end-to-end tests that test the public API surface and not just some implementation detail. We really want to preserve the ability to get a good overview of all end-to-end tests in a single location and so with this change we take necessary steps to expose necessary test helpers so that they can be used from end-to-end tests. Furthermore, we move said BPF symbolization tests into tests/blazesym.rs, co-located with most other end-to-end tests.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.39%. Comparing base (033a2e1) to head (54b9ecb). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #888 +/- ## ========================================== - Coverage 95.41% 95.39% -0.03% ========================================== Files 55 56 +1 Lines 10523 10459 -64 ========================================== - Hits 10041 9977 -64 Misses 482 482 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.