search

libcdio / libcdio-paranoia

CD paranoia on top of libcdio
GNU General Public License v3.0
50 stars 38 forks source link

Add check if linker supports version scripts #24

Closed boretom closed 4 years ago

boretom commented 4 years ago

Hi,

When I wanted to compile python audio-tools on my macOS 10.14 a few days ago and compiling the dependency libcdio-paranoia failed because the macOS linker doesn't support the --version-script argument. Searching the internet showed that Simon Josefsson wrote a M4 script to check for that support.

With that PR the ld-version-script.m4 script was added, plus of course the necessary changes to the build files.

Could you have look at the PR and see if you find it useful? Compiling and the checks where successfully tested on macOS 10.14 and Ubuntu 19.10 64-bit.

rocky commented 4 years ago

Looks good. Let's do it!

boretom commented 4 years ago

Thanx rocky, that was fast :) ... I forgot to mention that I also tested compiling and the tests on FreeBSD 12.0.

Edit: was to fast, compling was ok but tests failed but fails on master too.

Have a good day Thomas

rocky commented 4 years ago

Np.

Will be testing on other platforms as well. In general though we move forward, not back.

boretom commented 4 years ago

Ok great.

I did a short test on FreeBSD 12.0 and the checks works fine until and including libcdio-paranoia 10.2+0.94. And fail since then. I'll check later or create a an issue.