search

libcpr / cpr

C++ Requests: Curl for People, a spiritual port of Python Requests.
https://docs.libcpr.org/
Other
6.49k stars 924 forks source link

CPack support #894

Open Aposhian opened 1 year ago

Aposhian commented 1 year ago

Is your feature request related to a problem?

I want to package this as a debian package so that other packages can pull it in easily.

Possible Solution

Use CPack to generate deb packages. Basically just need to include cpack in the cmake so that post-build someone can call cpack -G DEB to actually generate the package.

Alternatives

You could do native packaging for deb, but that's more work.

Additional Context

No response

COM8 commented 1 year ago

@Aposhian thanks for opening this issue! We actually already had a few tries of people creating a .deb package (here). All of them failed at some point.

Using CPack would definitely be an alternative. Do you want to look into this? Else I will since I currently look into the process of packaging an RPM with CPack for a different project anyway.

Aposhian commented 1 year ago

Yeah I can give it a go. It shouldn't be too difficult to setup Cpack.

RogueScholar commented 11 months ago

I don't consider myself an elite packager, but I've had cpr building daily over on Launchpad for over six months on Launchpad, populating working deb packages in a PPA for another project. You can see the recipe here, along with the Git repo that houses the packaging files, in case you'd care to upstream them here. It did require patching your CMake configuration, though it wasn't anything too drastic.

It goes without saying that anyone is free to use the packages, the PPA or the packaging files for whatever they see fit, they're all out in the open for precisely that reason. Nor is this to say that building in support for the CPack system isn't a worthwhile time investment, I think it is since CPack is generally more forgiving than the Debian packaging toolchain. I'd love to see cpr land in the official Debian/Ubuntu package archives at some point, and perhaps this can be a starting point.

COM8 commented 11 months ago

@RogueScholar thanks for sharing this! You are more than welcome to upstream your cpack changes here. I think this would be a great addition.