In a <name> element, the child elements have to be in the following order for the XML to be valid JATS: surname?, given-names?, prefix?, suffix?. At the moment, given-names appears before surname.
The copyright-holder and copyright-statement hasn't updated. In 70548, another author was added. In the editor itself the Copyright statement has updated:
The JATS DTD is complaining about the generated ids:
Attribute value "...." of type ID must be an NCName when namespaces are enabled.
It's complaining about ids in this format 2e45bcfe-0f39-4e0c-a88a-2e621577b2d6.
I'm not precious about these ids (although eLife does have a particular convention atm). But they'll need to not start with a number in order for the XML to be valid JATS. Apparently this is because ids have to be NCNames, which is something I was unaware of. Practically, this means that the ids cannot contain the following characters: :, @, $, %, &, /, +, ,, ;, or parentheses, and cannot begin with a number, dot or minus character although these can appear later in the string.
The references aren't appearing in the correct order in the XML, but they are in the Editor. For example, note that the first Donkin reference in the Editor is fourth in the ref list, but in the XML it is 10th.
The authors for a patent reference need to be in a <person-group person-group-type="inventor"> element, but they are in a <person-group person-group-type="author">.
Something which I think was missed in the requirements laid out here is that the patent element needs to have an optional country attribute. We don't currently have a field for that in the Editor. See https://github.com/libero/editor/issues/105 for the requirement. We can tackle this after MVP though since it's unlikely Insights will have this type of reference.
The publication date is not in the XML (month and day are missing and the iso attribute is missing those values):
In a
<name>element, the child elements have to be in the following order for the XML to be valid JATS: surname?, given-names?, prefix?, suffix?. At the moment,given-namesappears beforesurname.The
copyright-holderandcopyright-statementhasn't updated. In 70548, another author was added. In the editor itself the Copyright statement has updated:But in the XML, the contents of
copyright-statementandcopyright-holderremain as© 2021, RuizandRuizrespectively, when based on the new author list they should be© 2021, Ruiz and DonkinandRuiz and Donkin.Attribute value "...." of type ID must be an NCName when namespaces are enabled.It's complaining about ids in this format
2e45bcfe-0f39-4e0c-a88a-2e621577b2d6.I'm not precious about these ids (although eLife does have a particular convention atm). But they'll need to not start with a number in order for the XML to be valid JATS. Apparently this is because ids have to be NCNames, which is something I was unaware of. Practically, this means that the ids cannot contain the following characters:
:,@,$,%,&,/,+,,,;, or parentheses, and cannot begin with a number, dot or minus character although these can appear later in the string.The references aren't appearing in the correct order in the XML, but they are in the Editor. For example, note that the first Donkin reference in the Editor is fourth in the ref list, but in the XML it is 10th.
The authors for a patent reference need to be in a
<person-group person-group-type="inventor">element, but they are in a<person-group person-group-type="author">.Something which I think was missed in the requirements laid out here is that the patent element needs to have an optional country attribute. We don't currently have a field for that in the Editor. See https://github.com/libero/editor/issues/105 for the requirement. We can tackle this after MVP though since it's unlikely Insights will have this type of reference.
The publication date is not in the XML (month and day are missing and the iso attribute is missing those values):