search

libfetion / libfetion-gui

Automatically exported from code.google.com/p/libfetion-gui
2 stars 0 forks source link

User information dialog not uniform with self/friends #108

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Individually set at fxbuddy and fxmainwindow, only one dialog is need,
should refine the code

Original issue reported on code.google.com by alsor.zhou on 20 Aug 2009 at 5:34

GoogleCodeExporter commented 9 years ago 
Yes, We can integrate them into one function. ~~~~

Original comment by libfet...@gmail.com on 20 Aug 2009 at 6:07

GoogleCodeExporter commented 9 years ago 
Take this~

Original comment by alsor.zhou on 21 Aug 2009 at 1:03

GoogleCodeExporter commented 9 years ago 
Why we need to handle the hP=true/false? what's the different?
IMHO, if hP=true, means self, and false means the friends? 

    if (account->personal)
    {
        hP = true;
    }

Original comment by alsor.zhou on 21 Aug 2009 at 1:08

GoogleCodeExporter commented 9 years ago 
If we didn't update account's info, the personal of account will be NULL.
If we update it, It will be not.

Original comment by libfet...@gmail.com on 21 Aug 2009 at 2:28

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
till r329, we can fetch self information when in second query. (see issue 114), 
now
we need to wait on libfetion library delivery a 'user_info_update_completed' 
event. 

Moving to Priority-Low, since it's not a blocker.

Original comment by alsor.zhou on 25 Aug 2009 at 7:25

GoogleCodeExporter commented 9 years ago 
When we got the  account->personal 's value is NULL, we can ignore those info.

I think it is the best way for this issue. :-)

Original comment by libfet...@gmail.com on 25 Aug 2009 at 7:44

GoogleCodeExporter commented 9 years ago 
Resolved in r330

Original comment by alsor.zhou on 25 Aug 2009 at 3:10