libhal-google / libhal

A collection of interfaces and abstractions for embedded peripherals and devices using modern C++
Apache License 2.0
86 stars 17 forks source link

Update ncc to allow for empty parameter names #505

Open kammce opened 1 year ago

kammce commented 1 year ago

This should be allowable:

void foo(int);

Rather than having to put in a useless variable name which then requires a [[maybe_unused]] attribute like so

void foo([[maybe_unused]] int p_not_used);
kammce commented 1 year ago

Using the following expression does not fix this issue: ^(p[a-z]+[a-z0-9]*|)$

So this likely requires an investigation and update to the NCC code base https://github.com/nithinn/ncc/blob/master/ncc.py