search

libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p
https://github.com/libp2p/specs/tree/master/pubsub
Other
317 stars 182 forks source link

PubSub Discovery for at topic stops if node initially starts with no peers #442

Open vishalchangrani opened 3 years ago

vishalchangrani commented 3 years ago

Hi, I am using the DHT mechanism for peer discovery. The pubsub lets you pass in a discovery object at startup which is great and simplifies the discovery process a lot since I don’t have to now right the ongoing Advertise and FindPeer calls for peers subscribed to same topic to find each other.

However, if I start a node initially with no peers (no connections), subscribe to a topic and then connect it to the peer running the DHT discovery, it fails to find other peers subscribed on the same topic.

The reason for it is that on this line the HandleDiscovery returns immediately with the error: error finding peers and unfortunately for that topic discovery loop stops.

dpatsora commented 2 years ago

+1

asjdf commented 11 months ago

Did you solve this issue?