search

libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p
https://github.com/libp2p/specs/tree/master/pubsub
Other
317 stars 182 forks source link

discovery.go: `MinTopicSize` does not include publishing host in `TopicSize` count. #462

Closed renaynay closed 2 years ago

renaynay commented 2 years ago

MinTopicSize is confusing as TopicSize is interpreted as total number of peers listening in on a topic, but in reality, the publishing host excludes itself from that number. It would be nice if this were either to be documented in the godocs or if TopicSize were to be changed so that it includes the publishing host in the count.

vyzo commented 2 years ago

sure, either works; care for a pr?

renaynay commented 2 years ago

Sure.

renaynay commented 2 years ago

https://github.com/libp2p/go-libp2p-pubsub/pull/463