Message buffer filled log message should be an error message

libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p

https://github.com/libp2p/specs/tree/master/pubsub

Other

323 stars 187 forks source link

Message buffer filled log message should be an error message #472

Open rllola opened 2 years ago

rllola commented 2 years ago

I have encounter the case where I filled the buffer faster than I was reading it and messages were dropped. Took me a while to figure out because I didn't see any errors.

I noticed the INFO message after a while (see https://github.com/libp2p/go-libp2p-pubsub/blob/master/pubsub.go#L928). It should be made more evident to people that messages are being dropped to avoid confusion by showing ERROR or at least a WARN tag in the logs.

lthibault commented 1 year ago

It seems to me this is definitely not an ERROR-level event, since it does not invalidate the state of the system.