libp2p / go-libp2p-pubsub

The PubSub implementation for go-libp2p
https://github.com/libp2p/specs/tree/master/pubsub
Other
317 stars 182 forks source link

Optimize Garbage Collection For Message Deliveries #569

Closed nisdas closed 1 month ago

nisdas commented 1 month ago

In the event a delivery record becomes old and expires, we also clear out the associated peer map tracking the different peers who have propagated the message.

Stebalien commented 1 month ago

We're deleting the entire map anyways. If something else is hanging onto a copy of that map (it shouldn't be) we should fix that. Clearing the map explicitly isn't going to clear memory any faster.

Closing for now but please tell me if I'm missing something obvious here.