libp2p / go-reuseport

reuse tcp/udp ports in golang
ISC License
767 stars 109 forks source link

Add `poll_darwin_arm.go` for iOS gomobile support #18

Closed tptee closed 7 years ago

tptee commented 7 years ago

Confirmed that this compiles and runs on iOS by:

This is assuming that the kqueue implementation for x86 Darwin is the same as on ARM Darwin.

tptee commented 7 years ago

Weird, tests pass on macOS for me. Anything I'm missing?

Kubuxu commented 7 years ago

For sure buildtag that locks this code to ios.

tptee commented 7 years ago

Oops! Added the build tag and tests pass now 👍

whyrusleeping commented 7 years ago

@Kubuxu @tptee wait a sec, does this only work on iOS? Or does this same fix also work for darwin (aka, normal macbooks)?

whyrusleeping commented 7 years ago

(also, apologies for the great delay)

whyrusleeping commented 7 years ago

ah, nvm. I see that this is just a slight fork of the base poll_bsd.go code.

@Kubuxu is this RFM?