feat: Rewrite from SIO+ws-relay to protobuf+p2p-circuit

libp2p / js-libp2p-websocket-star

libp2p-webrtc-star without webrtc. Just plain socket.io.

https://libp2p.io

39 stars 15 forks source link

feat: Rewrite from SIO+ws-relay to protobuf+p2p-circuit #43

Closed mkg20001 closed 6 years ago

mkg20001 commented 6 years ago

This PR is a full rewrite of libp2p-websocket-star. Major changes:

No more socket.io
p2p-circuit is handling relay

Server pr: https://github.com/libp2p/js-libp2p-websocket-star-rendezvous/pull/11

mkg20001 commented 6 years ago

PR is ready for review

mkg20001 commented 6 years ago

@libp2p/javascript-team Anybody mind reviewing this (and server pr)? Can I just merge that?

daviddias commented 6 years ago

@mkg20001 I need to review this PR and make sure it follows the model we have to achieve with https://github.com/libp2p/js-libp2p/issues/130. I plan to prioritize that and do it this week.

daviddias commented 6 years ago

Status Update:

This PR is currently blocked on https://github.com/libp2p/js-libp2p/issues/159 which will bring things like DI setup to libp2p. Lot's of work happening there.

Also, we will only be confident to move into a p2p-circuit solution once https://github.com/ipfs/interop/pull/6 is completely done.

Things that are part of this PR that are not part of the migration to p2p-circuit should happen in a separate PR, i.e Fixing memory leaks. @mkg20001 can you do that?

mkg20001 commented 6 years ago

@diasdavid The memory leaks are mainly socket.io's fault. I can try to split this pr up into multiple prs.

daviddias commented 6 years ago

Check out https://www.npmjs.com/package/pull-ws which is the one we use for https://github.com/libp2p/js-libp2p-websockets

mkg20001 commented 6 years ago

I think this is no longer needed