search

libp2p / specs

Technical specifications for the libp2p networking stack
https://libp2p.io
1.56k stars 273 forks source link

Add a limit of 8MiB to secio messages size #236

Closed tomaka closed 4 years ago

tomaka commented 4 years ago

This is apparently already the case in practice, but we should add it to the specs.

tomaka commented 4 years ago

They should be unified to either value. If the Go code sends a 6MiB frame to the JS, it will get refused, and that's an incompatibility.

jacobheun commented 4 years ago

They should be unified to either value. If the Go code sends a 6MiB frame to the JS, it will get refused, and that's an incompatibility.

Agreed. If no one has issues with this, JS can easily make the switch for the upcoming refactor release.