libp2p / specs

Technical specifications for the libp2p networking stack
https://libp2p.io
1.56k stars 273 forks source link

Make messageIDs bytes instead of strings #285

Closed rklaehn closed 4 years ago

rklaehn commented 4 years ago

Rationale:

This issue was discovered in https://github.com/libp2p/rust-libp2p/issues/1671 . There is a coresponding issue in go-ipfs-pubsub, https://github.com/libp2p/go-libp2p-pubsub/issues/361

Changing this should have no negative impact. Implementations that expect valid utf-8 strings are already broken, because go-ipfs emits non utf8 strings. See https://github.com/libp2p/go-libp2p-pubsub/issues/361#issuecomment-663569492