search

libp2p / specs

Technical specifications for the libp2p networking stack
https://libp2p.io
1.56k stars 273 forks source link

Consistent `SUCCESS` for relay status code #293

Closed tmakarios closed 3 years ago

tmakarios commented 4 years ago

Currently, the Status enum has SUCCESS as the name of the 100 status code, but the explanations of phases II and III use OK instead.

tmakarios commented 3 years ago

I would suggest removing the remaining OK in this pull request as well, see diff below, though I can open up a new pull request once this is merged.

That column in the table seems to be a somewhat human-readable message, but it's probably a good idea to change it to "success" or something, for consistency. I don't know what the usual procedure is, pull-request-wise.

mxinden commented 3 years ago

I don't know what the usual procedure is, pull-request-wise.

If you don't mind I would appreciate if you could include the diff above, otherwise I will do so in a follow up pull request. Feel free to use "success" instead of SUCCESS.

tmakarios commented 3 years ago

I think I've done that now.