search

libp2p / specs

Technical specifications for the libp2p networking stack
https://libp2p.io
1.56k stars 273 forks source link

Gossipsub: protobuf type of signedPeerRecord #300

Closed blacktemplar closed 3 years ago

blacktemplar commented 3 years ago

Is there any specific reason why the type of a signedPeerRecord in the protobuf message type PeerInfo (https://github.com/libp2p/specs/blob/master/pubsub/gossipsub/gossipsub-v1.1.md#protobuf) is bytes and not the protobuf message type Envelope defined in the specs https://github.com/libp2p/specs/blob/rfc/address-records/RFC/0002-signed-envelopes.md#wire-format?

mxinden commented 3 years ago

@vyzo do you know an answer here as a GossipSub expert?

vyzo commented 3 years ago

we wanted to avoid the dependency between protobufs and a fixed payload; the PX extension was implemented before the envelope spec was finalized.

On Wed, Apr 7, 2021, 18:18 Max Inden @.***> wrote:

@vyzo https://github.com/vyzo do you know an answer here as a GossipSub expert?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libp2p/specs/issues/300#issuecomment-815000192, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAI4SUKPW3N5YAWPN7BCITTHRZTVANCNFSM4SR6YGMA .

mxinden commented 3 years ago

Thanks @vyzo.

Closing here since the above answers the question. @blacktemplar please follow up with another comment in case you would like to continue the discussion.