search

libp2p / specs

Technical specifications for the libp2p networking stack
https://libp2p.io
1.56k stars 273 forks source link

p2p-circuit v2 spec #325

Closed vyzo closed 3 years ago

vyzo commented 3 years ago

Fleshed out the remaining sections and turned the thorny integers into unsigned.

@mxinden this should be ready for review; note the changes in the vouchers, they are now signed envelopes (which means both our implementations will need to change).

vyzo commented 3 years ago

summoning @Stebalien @raulk -- this is ready for your review.

jacobheun commented 3 years ago

@mxinden any concerns with landing this? The spec is still working draft so edits can still be subsequently pushed as needed until we hit Candidate Recommendation.

mxinden commented 3 years ago

@vyzo friendly ping. Can this be merged?

vyzo commented 3 years ago

needs a couple more edits, will get to it.

On Mon, Jun 7, 2021, 17:22 Max Inden @.***> wrote:

@vyzo https://github.com/vyzo friendly ping. Can this be merged?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/libp2p/specs/pull/325#issuecomment-855973065, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAI4SVRCGKD7M6XWBH55E3TRTI35ANCNFSM44EPM74Q .

vyzo commented 3 years ago

@raulk this should be ready for merge.

mxinden commented 3 years ago

@vyzo @raulk friendly ping. Any objections to this being merged?

vyzo commented 3 years ago

no objections from me, waiting on @raulk to green tick.