search

libp2p / specs

Technical specifications for the libp2p networking stack
https://libp2p.io
1.56k stars 273 forks source link

Fix tls.md #357

Closed kpp closed 3 years ago

kpp commented 3 years ago

The go implementation uses OCTET STRING instead of BIT STRING for elements of SignedKey.

The options are:

1) fix the go implementation 2) update the specs

However with 1) we should also notify every implementors to fix it, e.g. https://github.com/alanshaw/js-libp2p-quic/blob/1f3c1dd6dff3c2e94710a1ae76e815e0805c8a99/src/crypto.js#L44

Stebalien commented 3 years ago

Nice catch!

@mxinden what does rust-libp2p do here?

dvc94ch commented 3 years ago

Nothing yet, this was found by @kpp testing the upcoming rust implementation.

Stebalien commented 3 years ago

Thanks!

@raulk anyone else we should notify?

@dvc94ch related, are there any interop tests for rust? Either with go-libp2p or go-ipfs? We currently run interop tests with js-ipfs (using the IPFS HTTP API) and js-libp2p (using the daemon, also implemented in javascript).