search

libp2p / specs

Technical specifications for the libp2p networking stack
https://libp2p.io
1.56k stars 273 forks source link

add our metrics effort to the short-term roadmap #403

Closed marten-seemann closed 2 years ago

marten-seemann commented 2 years ago

Contrary to what I suggested in past discussions, I do now wonder whether we should standardize on a set of base metric names across the implementations. E.g. each implementation SHOULD expose libp2p_connection_established{transport="tcp", security="noise", muxer="yamux"}. We would only be consistent across implementations on a subset / base-set of metrics. What do you think @marten-seemann?

I think I've suggested that a while ago :) Fully agree.

mxinden commented 2 years ago

Contrary to what I suggested in past discussions, I do now wonder whether we should standardize on a set of base metric names across the implementations. E.g. each implementation SHOULD expose libp2p_connection_established{transport="tcp", security="noise", muxer="yamux"}. We would only be consistent across implementations on a subset / base-set of metrics. What do you think @marten-seemann?

I think I've suggested that a while ago :) Fully agree.

Yes, you did! Cool. I would suggest we define a set of base metrics here in the specs repository.