search

libpd / abl_link

Ableton Link integration for Pure Data on desktop and Android.
Other
80 stars 15 forks source link

use variables for paths to 3rd-party modules #1

Closed umlaeute closed 7 years ago

umlaeute commented 7 years ago

Closes https://github.com/libpd/pd-for-ios/issues/12

my use case is simple: i want to have abl_link~ in Debian. there are a few obstacles:

these obstacles are further supported by github, which doesn't include any git submodules into any generated zipfiles/tarballs (think tagged releases)

luckily, Debian has packaged both libasio and ableton_link (resp. their headers). Of course, the libasio header files (in /usr/include/asio) are independently usable of ableton-link, so they are not found in some random subdirectory of the abelton headers (in /usr/include/ableton).

unfortunately some compilers are rather picky when passing them non-existent include-directories (-I/path/to/nowhere). and since you are using cflags, those flags cannot be overwritten via the cmdline.

so i think it is better to make the include-paths for each 3rd-party library explicit and overridable.

umlaeute commented 7 years ago

ah, and since you are also using the pd-lib-builder Makefile but the tarballs do not include them, i would also like to ask you to make the exact position of this file configurable (in Debian I use the pd-lib-builder provided Makefile which can be found in /usr/share/pd-lib-builder)

nettoyeurny commented 7 years ago

Hmm, I see. I'm a little bit concerned about the idea of pulling in some shared copy of Makefile.pdlibbuilder because abl_link depends on a very recent revision this file. A shared copy might be quite stale. I think it might make more sense to just add a suitable snapshot of Makefile.pdlibbuilder to this repository. Thoughts?

danomatika commented 7 years ago

I don't think it's worth worrying about. Regular users will use it as is and if you're messing with the paths yourself, you're on your own (aka should know what you're doing).