libredeb / lightpad

LightPad is a lightweight, simple and powerful application launcher. It is also Wayland compatible.
GNU General Public License v3.0
58 stars 11 forks source link

xterm dependency #16

Open bashfulrobot opened 3 years ago

bashfulrobot commented 3 years ago

Hi there,

I was just removing xterm from my system using apt and noticed that it was also going to remove lightpad. It appears that xterm is a dependency. Is this by design?

sudo apt purge xterm
Reading package lists... Done
Building dependency tree       
Reading state information... Done
The following packages will be REMOVED:
  budgie-lightpad-applet* lightpad* xterm*
0 upgraded, 0 newly installed, 3 to remove and 0 not upgraded.

System

❯ /usr/bin/cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=20.10
DISTRIB_CODENAME=groovy
DISTRIB_DESCRIPTION="Ubuntu 20.10"
lightpad/groovy 0.0.8~rev2+build1 amd64
  LightPad is a lightweight, simple and powerful application launcher. Writen in GTK+ 3.0. It is also Wayland compatible.
fossfreedom commented 3 years ago

Yeah - I note the comment here https://github.com/libredeb/lightpad/blob/97695a57192fdb6ac7aa44ca3207777d740441ba/src/Application.vala#L240

The question of terminal support via Glib is a long long long discussion point.

My view is that it should be left to the user to install xterm/gnome-terminal/whatever rather than force them to install xterm as a dependency. If they haven't got a compatible Glib terminal installed then basically silently fail. That's what happens at the moment with Glib.

libredeb commented 3 years ago

@fossfreedom thanks for explaining very clearly. Just clarify that as a precaution the decision was made to put it as a dependency so that it would not fail.