libredirect / browser_extension

A browser extension that redirects popular sites to alternative privacy friendly frontends
https://libredirect.github.io
GNU General Public License v3.0
3.12k stars 113 forks source link

No longer works after I upgraded to Freetube 0.21 #953

Open roldengarm opened 3 weeks ago

roldengarm commented 3 weeks ago

This week I upgraded to Freetube 0.21.0 and then 0.21.1, but Libredirect has stopped working on youtube.com Page stays white (as before), but doesn't open Freetube.

Have rebooted PC, no difference. No errors either.

IkelAtomig commented 3 weeks ago

That's a serious acquisition, I would say, I have Freetube installed too and still works as intended for Playlists, Shorts and Videos URL. More details required to reproduce and fix.

roldengarm commented 3 weeks ago

It worked fine until I upgraded to 0.21 @IkelAtomig I have configured LibRedirect to open youtube links in Freetube.

Previously, when I would click a video result in my search engine, it would go to youtube.com (which would stay white) and then immediately open Freetube. It now no longer happens, just youtube.com stays white. No errors as far as I can tell.

IkelAtomig commented 3 weeks ago

We need details such as Browser and OS. That would help it. Worked for me just fine when clicking a youtube link from search results.

roldengarm commented 3 weeks ago

Firefox on Windows 11 @IkelAtomig Thanks

IkelAtomig commented 3 weeks ago

Alright, We devs are Linux users, will check it in our VM and look on it. P.S. It's Windows 10 not 11.

berenddeschouwer commented 3 weeks ago

I've got a similar problem on:

It started very recently, but I don't know if that's because of Firefox 127 -> 128, or a new Freetube.

Browser console log:

Browser tab refresh works, with the same browser console.

rustyechelle commented 3 weeks ago

same here, happens just today

i upgraded to firefox 128 yesterday and it was still working, maybe a minor firefox update or just the firefox reboot ? i upgraded to freetube v0.21.1 the day before that

IkelAtomig commented 3 weeks ago

To be honest this is absurd. I think we need to spin a lot of VMs to check this through. Cuz in our original machines they work great.

berenddeschouwer commented 3 weeks ago

It seems to depend on how youtube is started.

I'll try and narrow down test cases. If I manage to write a minimal .html page that triggers it, I'll post it.

For now, the following describes the behaviour I find.

Fail:

Success: (exact same page)

Success: (different page)

Speculation:

It depends on target=_blank and rel=noreferrer, or it depends on what Firefox thinks is a deliberate, user-driven (middle click) open-tab action vs. implicit open-tab action.

IkelAtomig commented 3 weeks ago

The first action seems to be after updating to Firefox v128. I was able to redirect to FreeTube in v127 when the issue was filed here.

I searched for a YouTube Video in Startpage which by default opens link in New tab. Yep, you are right. @berenddeschouwer - Thanks for the heads up. It really narrowed it down.

roldengarm commented 3 weeks ago

Likely related, in my case, I'm using Kagi and have configured it to open all links in a new tab. Based on what @berenddeschouwer said, when I middle click instead, it works fine. Hope this helps @IkelAtomig