Align wait-for-it host with libreoffice start command

libreofficedocker / libreoffice-unoserver

A packaged unoserver with REST APIs using Libreoffice in Docker

Apache License 2.0

10 stars 6 forks source link

Align wait-for-it host with libreoffice start command #7

Closed fetwar closed 7 months ago

fetwar commented 7 months ago

libreoffice start command uses the loopback address 127.0.0.1 instead of localhost.

This can cause issues in resolving to the correct address if:

The host machine uses external DNS resolution only and Docker DNS is not explicitly set.
/etc/nsswitch.conf is set to not check local files first.
The Docker DNS resolution is set for external name resolution only.

This ensures that regardless of DNS resolution issues on the host machine, the container will be able to run, since it doesn't really need these anyway.

fetwar commented 7 months ago

Please note, tests failed after the last commit ~3 months ago, I tried to fix this issue as well, but the Github actions logs have expired.

fetwar commented 7 months ago

@socheatsok78

mlarue commented 7 months ago

Had problems with rest-api not starting up and

127.0.0.1   localhost
::1 localhost ip6-localhost ip6-loopback

in containers /etc/hosts.

Workaround until this is merged:

docker run --rm --sysctl net.ipv6.conf.all.disable_ipv6=1 libreofficedocker/libreoffice-unoserver:3.18

For details see: https://github.com/moby/moby/pull/47062

socheatsok78 commented 7 months ago

Please note, tests failed after the last commit ~3 months ago, I tried to fix this issue as well, but the Github actions logs have expired.

The build only failed for the Alpine 3.19, the older releases are fine.

Will take a look at 3.19 later.