search

libretro / Genesis-Plus-GX

An enhanced port of Genesis Plus - accurate & portable Sega 8/16 bit emulator
Other
75 stars 71 forks source link

[feature request] pull-request "ForceVDP" option to ekeeke's branch. Minor GUI naming fix. #358

Closed eugene-s-nesdev closed 1 month ago

eugene-s-nesdev commented 1 month ago

@ds22x, Can you make pull request this commit (https://github.com/libretro/Genesis-Plus-GX/commit/ba9fc37cfa4930311a9c77b1d8a23df0cae95e9a) to the ekeeke's upstream libretro branch please?

Ekeeke said he would accept this PR: https://github.com/ekeeke/Genesis-Plus-GX/issues/558#issuecomment-2133954988

Can you, please, unify GUI naming according to the official ekeeke's wii/GC port and BizHawk port:

"NTSC" instead of "60Hz"
and
"PAL" instead of "50Hz"

https://github.com/ekeeke/Genesis-Plus-GX/blob/master/gx/docs/README.pdf ekeeke bizhawk

I guess "libretro_core_options.h" lines 144 and 145 will be look like this:

         { "auto",  "Disabled" },
         { "60hz",  "NTSC" },
         { "50hz",  "PAL" },
         { NULL, NULL },

instead of

         { "auto",  "Disabled" },
         { "60hz",  "60Hz" },
         { "50hz",  "50Hz" },
         { NULL, NULL },
eugene-s-nesdev commented 1 month ago

@ds22x Thank you!