search

libretro / LRPS2

GNU General Public License v2.0
159 stars 47 forks source link

Remove system > pcsx2 > bios requirement #237

Closed Gamr13 closed 1 year ago

Gamr13 commented 1 year ago

With this PR users can now simply place their PS2 BIOS files in the system folder, rather than in system > pcsx2 > bios

This will disrupt existing setups, as the core will no longer detect BIOS files in the system > pcsx2 > bios directory, but it also brings the PCSX2 core more in-line with almost every other core simply having their BIOS files in the system folder.

This PR is for consistency, and to simplify the RetroArch core setup process for end-users and will require changes to existing documentation.

If anyone has a better method to check for both the system & pcsx2 > bios directory, that'd be much better!

LibretroAdmin commented 1 year ago

Unfortunately it seems this causes a big regression where things don't work reliably anymore (can't even get a game to boot anymore), when I undo the PR it seems to work again. So we'll have to revert this for now. But later (after t3 fixes the process not closing properly first), we can definitely look at implementing this properly.