search

libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.4k stars 1.84k forks source link

MAME(current) game remap file wrongly named #15183

Open Tartifless opened 1 year ago

Tartifless commented 1 year ago

Description

When running a mame arcade game in CLI with current mame core, and saving the remap file for the game, the name of the file gets wrongly determined (i guess the parsing is wrong).

Actual behavior

Examples: CLI: retroarch.exe -L "C:\RetroBat\emulators\retroarch\cores\mame_libretro.dll" "dkong -skip_gameinfo -rompath C:\RetroBat6.0\roms\mame"

remap file = RetroBat6.rmp

CLI: retroarch.exe -L "C:\RetroBat\emulators\retroarch\cores\mame_libretro.dll" "dkong -skip_gameinfo -rompath C:\RetroBat\roms\mame"

remap file = mame.rmp

Expected behavior

The expectation is that the game remap file is named dkong.rmp

Steps to reproduce the bug

  1. Generate a .bat file to start retroarch.exe libretro mame core, add path arguments after the machine name:

retroarch.exe -L "C:\\mame_libretro.dll" "[machine_name] -skip_gameinfo -rompath C:\"

  1. Press F1 to access quick menu and go to input options
  2. Save game remap file and check the name

Version/Commit

Official 1.15 version of RetroArch and mame current 0.251 core.

sonninnos commented 9 months ago

Core does not matter since frontend is the one parsing the command and taking care of remap files based on the parsing. I suggest either putting dkong last on the command, since it is simply too much to ask for the frontend to start guessing otherwise what the content really is supposed to be in such cases.