search

libretro / RetroArch

Cross-platform, sophisticated frontend for the libretro API. Licensed GPLv3.
http://www.libretro.com
GNU General Public License v3.0
10.39k stars 1.84k forks source link

[Feature Request/Bug] Hardcore mode toggle for retro achievements in quick menu #8902

Open prataczak opened 5 years ago

prataczak commented 5 years ago

Description

If you go to Settings/Achievements and enable hardcore mode, then run a game, then open the RetroArch menu, in Quick Menu/Achievements, there is the option to 'Pause' hardcore mode, However, when you do so, rewind still doesn't work. This is the bug.

My feature request is to simply include the toggle to enable or disable hardcore mode in Quick Menu/Achievements, and do away with the 'Pause Hardcore Mode' toggle. Current implementation allows you to 'Pause' hardcore mode in Quick Menu/Achievements, but only if you already have hardcore mode enabled. If it isn't enabled, you have to leave the quick menu, and go to Settings/Achievements to change it.

Version/Commit

6c5d08d893

Environment information

andres-asm commented 5 years ago

I don't see the point. The Pause/Resume logic is better implemented than the toggle.

prataczak commented 5 years ago

But if you started in 'softcore' mode, and you want to enable hardcore mode, you have to navigate to Settings/Achievements to do so. The Pause/Resume toggle will only appear if you started in Hardcore mode to begin with.

Don't you think it would be nice to have an on/off toggle, instead of a conditional on/off toggle?

andres-asm commented 5 years ago

I don't think just toggling it in runtime will work properly anyway. I don't remember because I did this a long time ago but it seems pretty niche and overcomplicated considering all the options you have already.

andres-asm commented 5 years ago

A toggle outside settings is a weird thing because it's not immediately clear if it should save or not. What could be done is, there could be an "Enable Hardcore Mode" action there when the toggle in the main settings is off.

prataczak commented 5 years ago

That sounds cool, I like it.

Or, maybe have the 'pause' toggle there all the time, even when 'hardcore' mode is off, and just have it set to 'paused' automatically. Not sure if that would work, just throwing that out there. :)

orbea commented 5 years ago

What could be done is, there could be an "Enable Hardcore Mode" action there when the toggle in the main settings is off.

I think this is the best idea in this issue report.

prataczak commented 5 years ago

@orbea So you're saying 'Enable Hardcore Mode' toggle will appear where the 'Pause Hardcore Mode' toggle is, if Hardcore mode is off in the main settings, then once you enable it, it disappears, and the 'Pause Hardcore Mode' toggle appears like normal?

orbea commented 5 years ago

@fr500 I was just agreeing with @fr500 who is much more informed than me concerning hardcore mode.

prataczak commented 5 years ago

Oh right, sorry. I misunderstood. :)